[BUGFIX beta] Ensure @controller passes args correctly #17868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@controller was not passing args correctly for parameter-less decorator usage. We weren't actually testing it, which is why we didn't catch the issue. This adds tests for both @service and @controller and fixes the problem.
pzuraq
force-pushed
the
bugfix/ensure-controller-passes-args-properly
branch
from
33a3e3f
to
53e6a9c
Compare
rwjblue
approved these changes
Apr 8, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@controller was not passing args correctly for parameter-less decorator
usage. We weren't actually testing it, which is why we didn't catch the
issue. This adds tests for both @service and @controller and fixes the problem.